Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): no change deployment prints "hotswap deployment skipped" without hotswap flag #24602

Merged
merged 2 commits into from
Mar 17, 2023

Conversation

comcalvi
Copy link
Contributor

The "hotswap deployment skipped" message is printed when a full deployment is performed if no changes were detected.

Before:

$ cdk deploy
 ✨ hotswap deployment skipped - no changes were detected (use --force to override)


 ✅  ApiStack (no changes)

With this PR:

$ cdk deploy

 ✅  ApiStack (no changes)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team March 13, 2023 17:39
@github-actions github-actions bot added the p2 label Mar 13, 2023
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Mar 13, 2023
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation aws-cdk-automation added the pr/needs-cli-test-run This PR needs CLI tests run against it. label Mar 13, 2023
@rix0rrr rix0rrr added pr-linter/exempt-test The PR linter will not require test changes pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested labels Mar 15, 2023
@rix0rrr rix0rrr changed the title fix(CLI): no change deployment prints "hotswap deployment skipped" without hotswap flag fix(cli): no change deployment prints "hotswap deployment skipped" without hotswap flag Mar 15, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review March 15, 2023 09:41

✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation removed the pr/needs-cli-test-run This PR needs CLI tests run against it. label Mar 15, 2023
@mergify
Copy link
Contributor

mergify bot commented Mar 15, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: c85fdaa
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Mar 17, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 79151fd into aws:main Mar 17, 2023
homakk pushed a commit to homakk/aws-cdk that referenced this pull request Mar 28, 2023
…thout hotswap flag (aws#24602)

The "hotswap deployment skipped" message is printed when a full deployment is performed if no changes were detected. 

Before:

```
$ cdk deploy
 ✨ hotswap deployment skipped - no changes were detected (use --force to override)


 ✅  ApiStack (no changes)
```

With this PR:

```
$ cdk deploy

 ✅  ApiStack (no changes)
```
----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2 pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants